-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incus: update to 6.6; reverse dependency. #52384
Conversation
If you could take a look at let me know what you think I'd appreciate it, willing to make changes, especially to content of readme. I also have opened a PR for handbook docs void-linux/void-docs#815 and we can discuss what information should exist in readme vs handbook. |
Hey, the changes to incus make sense to me, thanks! I was also thinking it'd be useful to have man pages, something like
Can you try adding this? |
Sure! I'll work on getting the manpages added this weekend. For the subuid/subguid, I can leave it in. Maybe I should add something about checking current /etc/subuid /etc/subguid? Might not be necessary since if people do run it it'll hopefully be a no op, since base-files matches the range the read me suggests. |
9c2f674
to
ad2d1f6
Compare
Hey, this looks good to me. Should some man pages go into the tools subpkg? |
There are no man pages for "fuidshift-incus lxc-to-incus lxd-to-incus incus-benchmark incus-migrate incus-simplestreams" So it looks like they all go in the incus-client to me. incus-tools
incus
incus-client |
You're right, and this looks good to me. Thanks! |
yw, thanks for the feedback! |
ad2d1f6
to
773c54d
Compare
The commit message would more aptly be something along the lines of
|
773c54d
to
902953b
Compare
902953b
to
b95535b
Compare
b95535b
to
88d4aa6
Compare
Summarizing a quick conversation on IRC: -> maybe man page naming should be changed up stream There seem to be a few ways to move forward.
I don't mind whichever direction we want to take, but If there's a lot of debate I'd rather merge the original changes and decide what to do about man pages separately. |
300+ manpages just for regurgitated |
88d4aa6
to
a1819a2
Compare
I saved the other commit on a local branch, so can bring the man page changes back if we need it, but here's the PR without adding man pages |
I'm fine either way about man pages. |
incus-client is intended to be installed without the daemon to use to control remote incus servers. incus the daemon can't be used without the client, at least to authorize another client to access the API. I moved incus-user to the daemon package because it's a daemon and not part of the client. readme: I changed "and" to "or" because the two groups grant you access to the daemons in different privelege levels.
@dkwo I'm running the 6.6 update now to test, and have added it to this PR, unless you'd rather have it in a separate one. |
a1819a2
to
e3f4da0
Compare
v6.6 works fine for me. |
It's also been solid for me. Tested some vm stuff too just in case. |
incus-client is intended to be installed without the daemon to use to control remove incus servers. incus the daemon can't me used without the client, at least to authorize another client's to access the API.
I moved incus-user to the daemon package because it's a daemon and not part of the client.
readme: I also removed the information about subuid and subgid because void sets these up out of the box.
readme: I changed "and" to "or" because the two groups grant you access to the daemons in different privelege levels.
Testing the changes
Local build testing
x86_64-glibc
x86_64-musl
(cross) aarch64-musl
(cross) armv7l
(cross) armv6l-musl