Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing phosphor libraries - 404 #468

Closed
timkpaine opened this issue Nov 7, 2019 · 1 comment
Closed

Missing phosphor libraries - 404 #468

timkpaine opened this issue Nov 7, 2019 · 1 comment

Comments

@timkpaine
Copy link
Member

timkpaine commented Nov 7, 2019 •
edited
Loading

Looks like this isnt enough for libraries that heavily use phosphor. I'm getting 404s on

  • @phosphor/signaling
  • @phosphor/virtualdom
  • @phosphor/algorithm
  • @phosphor/commands
  • @phosphor/domutils
@timkpaine
Copy link
Member Author

I've confirmed that this works when fixed in the same way (npm install the library, add it after @phosphor/widget).

SylvainCorlay added a commit that referenced this issue May 18, 2020
@SylvainCorlay
Merge pull request #481 from timkpaine/phosphor
c2df4a8 
fixes #468 - bugfixes for libraries that use other phosphor libs present in JupyterLab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@timkpaine