-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generated response includes 12k lines of css #77
Comments
jf---
changed the title
generated response include
generated response includes 12k lines of css
Mar 11, 2019
Bootstrap
jf---
added a commit
to jf---/voila
that referenced
this issue
Mar 11, 2019
inlined bootstrap is now linked rather than inlined in initial response
Closed
I am not sure #78 is the right solution, but I indeed think we should not inline all the css this way, I'll give it some thought. |
Now that we are loading CSS sepatetely (in master), I think that we can close this specific issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that when hosting a notebook with voila, that in the initial response, 12k lines of
bootstrap css
is included. While mostjs
code is cached, this initial response is not and takes little under 3.00 seconds to complete. About 95% of the response data is thecss
code. It seems low hanging fruit to just link the dependency ( as is done for font-awesome ) or is served as a separate file, such that the browser can perform caching.this applies to the template:
voila/share/jupyter/voila/template/default/nbconvert_templates/voila.tpl
here the
css code
is inlined in the templatewhereas
voila/share/jupyter/voila/template/gridstack/nbconvert_templates/voila.tpl
inlines the bootstrap css
This reduces the response considerable...
The text was updated successfully, but these errors were encountered: