Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for ipywidgets 8 #1046

Merged

Conversation

mariobuikhuizen
Copy link
Member

Code changes

  • update dependencies to ipywidgets 8
  • use renamed method and property

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch mariobuikhuizen/voila/feat_widgets_8_support

@ruomad
Copy link

ruomad commented Feb 27, 2022

Any news on this topic (ipywidgets 8.0.0b1 support) ?
I'm currently stuck with voila not displaying widgets, and ipywidgets-8 provides important new functionalities (resizing window, textcolor in buttons, etc...
Would be really nice to have voila work with this !

@martinRenou
Copy link
Member

I believe we will not be making a Voila release compatible with ipywidgets 8 before it is actually out. Because it would make Voila dependent on ipywidgets 8, and we don't want that yet.

packages/voila/package.json Outdated Show resolved Hide resolved
@jtpio
Copy link
Member

jtpio commented Sep 5, 2022

Thanks @mariobuikhuizen for doing the update 👍

There is some overlap with #846 which also updates to ipywidgets 8. But it could be nice to do the update separately like in this PR so it could then be released in a 0.3.x.

@jtpio jtpio force-pushed the feat_widgets_8_support branch from f3420ea to dbced04 Compare September 6, 2022 10:16
@jtpio jtpio added this to the 0.3.x milestone Sep 6, 2022
@jtpio
Copy link
Member

jtpio commented Sep 6, 2022

FYI @mariobuikhuizen I rebased this branch to fix the conflicts and updated to the latest (final) @jupyter-widgets packages.

This looks good locally:

image

@jtpio jtpio linked an issue Sep 6, 2022 that may be closed by this pull request
ipympl==0.8.7
ipyvolume
ipympl==0.9.2
ipyvolume @ git+https://github.com/jtpio/ipyvolume@ipywidgets-8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @maartenbreddels it would be great to have a release of ipyvolume with support for ipywidgets 8: widgetti/ipyvolume#411, thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2022

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 119 <- [139 - 170 - 223] -> 401 66 <- [70 - 77 - 92] -> 126 68 <- [72 - 82 - 88] -> 115 62 <- [64 - 70 - 82] -> 101 2263 <- [2313 - 2374 - 2461] -> 3347 2133 <- [2166 - 2255 - 2403] -> 2817 2303 <- [2364 - 2429 - 2439] -> 2704 2225 <- [2235 - 2281 - 2369] -> 2604 1717 <- [1739 - 1753 - 1825] -> 1894 3136 <- [3235 - 3387 - 3621] -> 4486 7819 <- [7826 - 7841 - 7845] -> 7896 5481 <- [5539 - 5583 - 5735] -> 6053 1046 <- [1114 - 1126 - 1128] -> 1160 3294 <- [3551 - 3984 - 5084] -> 8171
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-09-06 12:40:32.282740782 +0000
+++ /dev/fd/62	2022-09-06 12:40:32.282740782 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8370C",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
-        "l1d": 98304,
+        "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 50331648
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "106",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.8,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "6",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281307648
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1017-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.4 LTS",
-      "serial": "1658ea69262c46798282e5c326bee33b",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio jtpio mentioned this pull request Sep 8, 2022
3 tasks
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's not wait for ipyvolume to get updated. We only depend on it for visual regression tests anyway.

@jtpio jtpio mentioned this pull request Sep 29, 2022
pllim added a commit to pllim/jdaviz that referenced this pull request Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for ipywidgets 8
5 participants