Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couple of ui-tests maintenance changes #1214

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

martinRenou
Copy link
Member

References

As far as I understand the jupyter_server_config.py config file was not used. Also showing the error traceback will be useful when the Notebook fails.

Code changes

User-facing changes

Backwards-incompatible changes

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/couple_ui_tests_tweaks

@martinRenou martinRenou force-pushed the couple_ui_tests_tweaks branch from 402bdd3 to 4b6023c Compare September 28, 2022 12:47
@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file voila-tree-classic.ipynb voila-tree-light.ipynb voila-tree-dark.ipynb voila-tree-miami.ipynb basics.ipynb bqplot.ipynb dashboard.ipynb gridspecLayout.ipynb interactive.ipynb ipympl.ipynb ipyvolume.ipynb multiple_widgets.ipynb query-strings.ipynb reveal.ipynb
Render
chromium
actual 85 <- [94 - 111 - 147] -> 237 65 <- [69 - 79 - 98] -> 138 67 <- [71 - 81 - 100] -> 147 68 <- [73 - 81 - 93] -> 133 2278 <- [2417 - 2466 - 2578] -> 3372 2173 <- [2215 - 2249 - 2293] -> 2530 2300 <- [2302 - 2368 - 2408] -> 2732 2282 <- [2312 - 2368 - 2478] -> 2675 1605 <- [1608 - 1649 - 1693] -> 1908 2891 <- [2893 - 2912 - 3003] -> 3294 8206 <- [8227 - 8242 - 8406] -> 8538 6118 <- [6133 - 6165 - 6286] -> 6345 1133 <- [1285 - 1287 - 1319] -> 1323 2135 <- [2192 - 2253 - 2414] -> 2612
expected 3379 <- [3442 - 3517 - 3701] -> 3876 2976 <- [3227 - 3321 - 3421] -> 3604 3608 <- [3623 - 3709 - 3793] -> 3825 4453 <- [4453 - 4523 - 4661] -> 4748 2559 <- [2655 - 2656 - 2660] -> 2674 3982 <- [4079 - 4213 - 4356] -> 4743 12183 <- [18509 - 19553 - 20811] -> 21515 15319 <- [15660 - 15796 - 15912] -> 16056 1517 <- [1920 - 1997 - 2103] -> 2113

❗ Test metadata have changed
--- /dev/fd/63	2022-09-28 13:43:04.635510260 +0000
+++ /dev/fd/62	2022-09-28 13:43:04.635510260 +0000
@@ -4,37 +4,37 @@
     "BENCHMARK_REFERENCE": "actual"
   },
   "browsers": {
-    "chromium": "97.0.4666.0"
+    "chromium": "94.0.4595.0"
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® Platinum 8370C",
+      "brand": "Xeon® E5-2673 v3",
       "cache": {
-        "l1d": 98304,
+        "l1d": 65536,
         "l1i": 65536,
-        "l2": 2097152,
-        "l3": 50331648
+        "l2": 524288,
+        "l3": 31457280
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "106",
+      "model": "63",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.8,
+      "speed": 2.4,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "6",
+      "stepping": "2",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7281315840
+      "total": 7291699200
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.15.0-1020-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
-      "release": "20.04.5 LTS",
-      "serial": "1d24188fee7f4944b0cb9c8863cdca51",
+      "release": "20.04.3 LTS",
+      "serial": "cfc067bfcb844f35865e279a1b0e66c5",
       "servicepack": "",
       "uefi": false
     }

@jtpio
Copy link
Member

jtpio commented Sep 29, 2022

As far as I understand the jupyter_server_config.py config file was not used.

Probably this a leftover of the initial approach which was to start JupyterLab to run the UI tests.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 98ce098 into voila-dashboards:main Sep 29, 2022
@jtpio jtpio added this to the 0.3.x milestone Sep 29, 2022
@jtpio
Copy link
Member

jtpio commented Sep 29, 2022

meeseeksdev please backport to 0.3.x

meeseeksmachine pushed a commit to meeseeksmachine/voila that referenced this pull request Sep 29, 2022
@martinRenou martinRenou deleted the couple_ui_tests_tweaks branch September 29, 2022 07:05
martinRenou added a commit that referenced this pull request Sep 29, 2022
…4-on-0.3.x

Backport PR #1214 on branch 0.3.x (Couple of ui-tests maintenance changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants