-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support specifying template from notebook metadata #629
Conversation
example format: {"voila":{"template","default"}}
this probably needs documentation, and I would expect the command line |
voila already has --template options, in standalone mode. |
I like it, and this is something we wanted to have for quite a while, and should almost be possible now that #208 is merged. There still is an issue though. Depending on the template, the static files that are served are different. I'll see if I can work on that.
I would expect the metadata to be more specific since it 'belongs' to the notebook. You can imagine having 2 notebooks with 2 different templates. While I see the cmd line argument (or the trait value) as a 'default' (least priority). |
@maartenbreddels right but if you want a unified look and feel you don't want individual notebooks breaking that. Just means yet another customization we'll have to do (stripping metadata) to make voila more friendly for enterprise. |
I think indeed it should be possible to disable that, with exactly that use
case in mind. Would you be happy with that?
(from mobile phone)
…On Tue, 23 Jun 2020, 18:54 Tim Paine, ***@***.***> wrote:
@maartenbreddels <https://github.com/maartenbreddels> right but if you
want a unified look and feel you don't want individual notebooks breaking
that. Just means yet another customization we'll have to do (stripping
metadata) to make voila more friendly for enterprise.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#629 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANPEPIP4KAVG4I6CR3NOX3RYDM3VANCNFSM4N5YWJ3A>
.
|
Replaced by #637 |
metadata format:
{
"voila": {
"template": "voila-vuetify"
}
}