Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support specifying template from notebook metadata #629

Closed
wants to merge 3 commits into from

Conversation

cailiang9
Copy link
Contributor

metadata format:
{
"voila": {
"template": "voila-vuetify"
}
}

@timkpaine
Copy link
Member

this probably needs documentation, and I would expect the command line --template to take precedence over the notebook metadata

@cailiang9
Copy link
Contributor Author

voila already has --template options, in standalone mode.
template options in notebook metadata will allow debugging in jupyter, other than standalone mode.

@cailiang9 cailiang9 changed the title Support specifying from notebook metadata Support specifying template from notebook metadata Jun 21, 2020
@maartenbreddels
Copy link
Member

I like it, and this is something we wanted to have for quite a while, and should almost be possible now that #208 is merged. There still is an issue though. Depending on the template, the static files that are served are different. I'll see if I can work on that.

I would expect the command line --template to take precedence over the notebook metadata

I would expect the metadata to be more specific since it 'belongs' to the notebook. You can imagine having 2 notebooks with 2 different templates. While I see the cmd line argument (or the trait value) as a 'default' (least priority).

@timkpaine
Copy link
Member

@maartenbreddels right but if you want a unified look and feel you don't want individual notebooks breaking that. Just means yet another customization we'll have to do (stripping metadata) to make voila more friendly for enterprise.

@maartenbreddels
Copy link
Member

maartenbreddels commented Jun 23, 2020 via email

@maartenbreddels
Copy link
Member

Replaced by #637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants