-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup executor resources after execution #969
Merged
jtpio
merged 1 commit into
voila-dashboards:main
from
martinRenou:cleanup_executor_resources
Sep 17, 2021
Merged
Cleanup executor resources after execution #969
jtpio
merged 1 commit into
voila-dashboards:main
from
martinRenou:cleanup_executor_resources
Sep 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please don't merge yet, just trying the CI |
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2021-09-17 08:10:37.276982177 +0000
+++ /dev/fd/62 2021-09-17 08:10:37.276982177 +0000
@@ -8,27 +8,27 @@
},
"systemInformation": {
"cpu": {
- "brand": "Xeon® E5-2673 v4",
+ "brand": "Xeon® E5-2673 v3",
"cache": {
"l1d": 65536,
"l1i": 65536,
"l2": 524288,
- "l3": 52428800
+ "l3": 31457280
},
"cores": 2,
"family": "6",
- "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+ "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
"governor": "",
"manufacturer": "Intel®",
- "model": "79",
+ "model": "63",
"physicalCores": 2,
"processors": 1,
"revision": "",
"socket": "",
- "speed": 2.3,
+ "speed": 2.4,
"speedMax": null,
"speedMin": null,
- "stepping": "1",
+ "stepping": "2",
"vendor": "GenuineIntel",
"virtualization": false,
"voltage": ""
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.8.0-1041-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
"release": "20.04.3 LTS",
- "serial": "faac5b9e00cf4ae3b2d2c013e98d933a",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
jtpio
approved these changes
Sep 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
trungleduc
added a commit
to trungleduc/voila
that referenced
this pull request
Sep 17, 2021
trungleduc
added a commit
to trungleduc/voila
that referenced
this pull request
Sep 22, 2021
trungleduc
added a commit
to trungleduc/voila
that referenced
this pull request
Sep 27, 2021
trungleduc
added a commit
to trungleduc/voila
that referenced
this pull request
Oct 4, 2021
martinRenou
added a commit
to martinRenou/voila
that referenced
this pull request
Jun 22, 2023
Revert voila-dashboards#969 This should never have been merged. The client still needs the kernel and channels running after execution ! Co-authored-by: davidbrochart <davidbrochart@users.noreply.github.com>
martinRenou
added a commit
to martinRenou/voila
that referenced
this pull request
Jun 23, 2023
Revert voila-dashboards#969 This should never have been merged. The client still needs the kernel and channels running after execution ! Co-authored-by: davidbrochart <davidbrochart@users.noreply.github.com>
martinRenou
added a commit
to martinRenou/voila
that referenced
this pull request
Jun 26, 2023
Revert voila-dashboards#969 This should never have been merged. The client still needs the kernel and channels running after execution ! Co-authored-by: davidbrochart <davidbrochart@users.noreply.github.com>
martinRenou
added a commit
that referenced
this pull request
Jun 28, 2023
* Do not clean up resources after execution Revert #969 This should never have been merged. The client still needs the kernel and channels running after execution ! Co-authored-by: davidbrochart <davidbrochart@users.noreply.github.com> * Only clean the kernel client --------- Co-authored-by: davidbrochart <davidbrochart@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring solutions for #896