Update randomize.go #275
Closed
Update randomize.go #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change rollbacks sqlboiler to an older version of satori/uuid so it is
not eligible to be merged.
…On Thu, 12 Apr 2018 at 17:37, Brian Voelker ***@***.***> wrote:
Doesnt return an error anymore
------------------------------
You can view, comment on, or merge this pull request online at:
#275
Commit Summary
- Update randomize.go
File Changes
- *M* randomize/randomize.go
<https://github.com/volatiletech/sqlboiler/pull/275/files#diff-0> (15)
Patch Links:
- https://github.com/volatiletech/sqlboiler/pull/275.patch
- https://github.com/volatiletech/sqlboiler/pull/275.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#275>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACIPlhsHW2mKWDJfmPesfEZf-IU_CvCaks5tn3TFgaJpZM4TSBrn>
.
|
|
I would suggest add dep to ensure things are using certain versions of dependencies cause right now i get build errors. |
|
Just update your library satori/uuid. |
|
As @saulortega mentioned, this is not eligible to be merged. The current version of satori/uuid has the error parameter, and if we merged this many users of sqlboiler will no longer be able to build. This is also a breaking change so something I can't make lightly. I think the best path is to update your version of uuid. sqlboiler won't commit to dep because it doesn't look like the community has, probably looking at vgo when that comes out. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesnt return an error anymore