Fix the scheduler panic whenever the GPU is lost on node #38
Conversation
volcano-sh-bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pkg/scheduler/api/node_info.go
Outdated
| @@ -161,6 +161,19 @@ func (ni *NodeInfo) SetNode(node *v1.Node) { | |||
| } | |||
| } | |||
|
|
|||
| func (ni *NodeInfo) updateIdleRes(ti *TaskInfo) bool { | |||
There was a problem hiding this comment.
s/updateIdleRes/allocateIdleResource
and return error instead of bool
|
/cc @hex108 @kinglion811 |
|
@william-wang , please help to move this PR to volcano-sh/volcano and cherry-pick to kube-batch later :) /close |
|
@k82cn: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
The volcano-sh/scheduler panics when startup whever the GPU is lost on nodes.
The cause is that the GPU resource descreaced, the node.idle <task.Req. The panic happened
when ni.Idle.Sub(ti.Resreq). This PR is used to fix the issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes volcano-sh/volcano#294
Special notes for your reviewer: