Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RestartPod action for pod reschedule #143

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

bibibox
Copy link
Contributor

@bibibox bibibox commented Nov 22, 2024

prepare for the volcano issue volcano-sh/volcano#3812

Correct the misunderstanding in this PR #141
In the context of the Volcano scheduler, task and pod are the same type of resource.
However, in Volcano controllers, a task is a higher-level resource above a pod. A single Volcano job can contain multiple tasks, and each task can include multiple pods.

Signed-off-by: Box Zhang <wszwbsddbk@gmail.com>
@Monokaix
Copy link
Member

Is this pr still needed?#141 has removed restartPod.

@bibibox
Copy link
Contributor Author

bibibox commented Nov 30, 2024

Is this pr still needed?#141 has removed restartPod.

yes, reference the description

@wangyang0616
Copy link
Member

/lgtm

@Monokaix
Copy link
Member

Monokaix commented Dec 3, 2024

/lgtm

@william-wang
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 3b1a101 into volcano-sh:master Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants