Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network topology API definition #144

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Network topology API definition #144

merged 1 commit into from
Dec 18, 2024

Conversation

Monokaix
Copy link
Member

@Monokaix Monokaix commented Nov 26, 2024 •
edited
Loading

API change for volcano-sh/volcano#3850

  1. Add a new CRD hyperNode.
  2. Add topology spec for vc job.
  3. Add topology spec for podGroup.
  4. Auto generation API client codes.

@Monokaix Monokaix force-pushed the network-topo branch 2 times, most recently from eb96d8d to 038f864 Compare November 26, 2024 03:37
penggu
penggu reviewed Nov 27, 2024
View reviewed changes
Copy link

@penggu penggu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only found a couple of code duplications and empty line changes (see comments in individual files for details). Not sure if those are necessary - please excuse my ignorance if those are actually desired. Other than that, everything looks good!

@Monokaix Monokaix force-pushed the network-topo branch 2 times, most recently from 2010613 to 793b1b3 Compare November 27, 2024 08:55
@ZhengXinwei-F
Copy link

ZhengXinwei-F commented Nov 28, 2024 •
edited
Loading

What is the milestone for the network topology feature?

dongjiang1989
dongjiang1989 reviewed Nov 29, 2024
View reviewed changes
pkg/apis/batch/v1alpha1/job.go Outdated Show resolved Hide resolved
pkg/apis/batch/v1alpha1/job.go Outdated Show resolved Hide resolved
@Monokaix Monokaix force-pushed the network-topo branch 3 times, most recently from 0295bc1 to 0e25160 Compare December 7, 2024 09:12
@Monokaix
Copy link
Member Author

Monokaix commented Dec 7, 2024

penggu

Will have a POC release in v2.0.

william-wang
william-wang reviewed Dec 10, 2024
View reviewed changes
pkg/apis/bus/v1alpha1/actions.go Outdated
// RestartPodAction if this action is set, only the pod will be restarted
// It means that only the pod corresponding to the event will be deleted and recreated.
// This action can just work together with pod level events, e.g. PodFailed
RestartPodAction Action = "RestartPod"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems to have no relation with network topology.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commits is synced from master branch, will submit a seperate pr later.

william-wang
william-wang reviewed Dec 10, 2024
View reviewed changes
pkg/apis/flow/v1alpha1/jobflow_types.go Outdated
TaskName string `json:"taskName,omitempty"`
Path string `json:"path,omitempty"`
Port int `json:"port,omitempty"`
// +optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have so many lines unrelated to this project been added?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These commits is synced from master branch, will submit a seperate pr later.

@Monokaix
Copy link
Member Author

/assign

This was referenced Dec 12, 2024
Merged
Merged
@Xu-Wentao Xu-Wentao mentioned this pull request Dec 13, 2024
Open
@william-wang
Copy link
Member

Looks good to me now.
/approve

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Monokaix
Add hyperNode CRD and add networkTopology spec for job
6aa1e55 
Signed-off-by: Monokaix <changxuzheng@huawei.com>
@kevin-wangzefeng
Copy link
Member

/lgtm
Thanks!

@volcano-sh-bot volcano-sh-bot merged commit e5d361b into volcano-sh:network-topology-dev Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@dongjiang1989 dongjiang1989 dongjiang1989 left review comments

@penggu penggu penggu left review comments

@william-wang william-wang william-wang left review comments

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@kevin-wangzefeng kevin-wangzefeng

@Monokaix Monokaix

Labels
approved lgtm size/XXL
Projects
Network Topology Aware Scheduling
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Monokaix @ZhengXinwei-F @william-wang @volcano-sh-bot @kevin-wangzefeng @penggu @dongjiang1989