Fix PodTopologySpread in predicate

Signed-off-by: Box Zhang <wszwbsddbk@gmail.com>
volcano-sh · Dec 16, 2024 · 395eb7c · 395eb7c
1 parent a392818
commit 395eb7c
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/scheduler/plugins/predicates/predicates.go b/pkg/scheduler/plugins/predicates/predicates.go
@@ -539,10 +539,12 @@ func (pp *predicatesPlugin) OnSessionOpen(ssn *framework.Session) {
 				status := podTopologySpreadFilter.Filter(context.TODO(), state, task.Pod, nodeInfo)
 				podTopologyStatus := api.ConvertPredicateStatus(status)
 				if podTopologyStatus.Code != api.Success {
+					// TODO: Currently, preemption is not supported when Pod Topology Spread filtering fails.
+					// Once supported, the logic here should be removed.
+					// See https://github.com/volcano-sh/volcano/issues/3845
+					podTopologyStatus.Code = api.UnschedulableAndUnresolvable
 					predicateStatus = append(predicateStatus, podTopologyStatus)
-					if ShouldAbort(podTopologyStatus) {
-						return api.NewFitErrWithStatus(task, node, predicateStatus...)
-					}
+					return api.NewFitErrWithStatus(task, node, predicateStatus...)
 				}
 			}
 		}