Skip to content

Commit

Permalink
Merge pull request #181 from lminzhw/vkctl_job_run_limits
Browse files Browse the repository at this point in the history
support vkctl job run --limits
  • Loading branch information
volcano-sh-bot authored May 18, 2019
2 parents 8dd6863 + 72d86d6 commit 5fc5713
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pkg/cli/job/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ type runFlags struct {
MinAvailable int
Replicas int
Requests string
Limits string
}

var launchJobFlags = &runFlags{}
Expand All @@ -48,6 +49,7 @@ func InitRunFlags(cmd *cobra.Command) {
cmd.Flags().IntVarP(&launchJobFlags.MinAvailable, "min", "m", 1, "the minimal available tasks of job")
cmd.Flags().IntVarP(&launchJobFlags.Replicas, "replicas", "r", 1, "the total tasks of job")
cmd.Flags().StringVarP(&launchJobFlags.Requests, "requests", "R", "cpu=1000m,memory=100Mi", "the resource request of the task")
cmd.Flags().StringVarP(&launchJobFlags.Limits, "limits", "L", "cpu=1000m,memory=100Mi", "the resource limit of the task")
}

var jobName = "job.volcano.sh"
Expand All @@ -63,6 +65,11 @@ func RunJob() error {
return err
}

limit, err := populateResourceListV1(launchJobFlags.Limits)
if err != nil {
return err
}

job := &vkapi.Job{
ObjectMeta: metav1.ObjectMeta{
Name: launchJobFlags.Name,
Expand All @@ -88,6 +95,7 @@ func RunJob() error {
Name: launchJobFlags.Name,
ImagePullPolicy: v1.PullIfNotPresent,
Resources: v1.ResourceRequirements{
Limits: limit,
Requests: req,
},
},
Expand Down

0 comments on commit 5fc5713

Please sign in to comment.