Merge pull request #18 from volcano-sh/opt/ensure_golint_exists

Ensure golint binary exists before linting

hack/.golint_failures

@@ -7,28 +7,17 @@ volcano.sh/volcano/pkg/apis/batch/v1alpha1
 volcano.sh/volcano/pkg/apis/bus/v1alpha1
 volcano.sh/volcano/pkg/apis/helpers
 volcano.sh/volcano/pkg/cli/job
-volcano.sh/volcano/pkg/client/clientset/versioned
-volcano.sh/volcano/pkg/client/clientset/versioned/fake
-volcano.sh/volcano/pkg/client/clientset/versioned/scheme
-volcano.sh/volcano/pkg/client/clientset/versioned/typed/batch/v1alpha1
-volcano.sh/volcano/pkg/client/clientset/versioned/typed/batch/v1alpha1/fake
-volcano.sh/volcano/pkg/client/clientset/versioned/typed/bus/v1alpha1
-volcano.sh/volcano/pkg/client/clientset/versioned/typed/bus/v1alpha1/fake
 volcano.sh/volcano/pkg/controllers/job
 volcano.sh/volcano/pkg/controllers/job/apis
 volcano.sh/volcano/pkg/controllers/job/cache
 volcano.sh/volcano/pkg/controllers/job/state
-volcano.sh/volcano/pkg/scheduler/actions
 volcano.sh/volcano/pkg/scheduler/actions/allocate
 volcano.sh/volcano/pkg/scheduler/actions/backfill
 volcano.sh/volcano/pkg/scheduler/actions/preempt
 volcano.sh/volcano/pkg/scheduler/actions/reclaim
-volcano.sh/volcano/pkg/scheduler/algorithm/fairshare
-volcano.sh/volcano/pkg/scheduler/plugins
 volcano.sh/volcano/pkg/scheduler/plugins/conformance
 volcano.sh/volcano/pkg/scheduler/plugins/drf
 volcano.sh/volcano/pkg/scheduler/plugins/gang
-volcano.sh/volcano/pkg/scheduler/plugins/nodeorder
 volcano.sh/volcano/pkg/scheduler/plugins/predicates
 volcano.sh/volcano/pkg/scheduler/plugins/priority
 volcano.sh/volcano/pkg/scheduler/plugins/proportion

hack/verify-golint.sh

@@ -9,6 +9,12 @@ source "${KUBE_ROOT}/hack/lib/init.sh"
 
 kube::golang::verify_go_version
 
+if ! which golint > /dev/null; then
+  echo 'Can not find golint, install with:'
+  echo 'go get -u github.com/golang/lint/golint'
+  exit 1
+fi
+
 cd "${KUBE_ROOT}"
 
 array_contains () {
@@ -54,7 +60,7 @@ for p in "${all_packages[@]}"; do
 	# and not just the ones for the current platform.
 	# Packages with a corresponding foo_test package will make golint fail
 	# with a useless error. Just ignore that, see golang/lint#68.
-	failedLint=$(golint "$p" 2>/dev/null)
+	failedLint=$(golint "$p"/*.go 2>/dev/null)
 	array_contains "$p" "${failing_packages[@]}" && in_failing=$? || in_failing=$?
 	if [[ -n "${failedLint}" ]] && [[ "${in_failing}" -ne "0" ]]; then
 		errors+=( "${failedLint}" )