Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to add a phase completed for podgroup #2056

Closed
Thor-wl opened this issue Mar 7, 2022 · 8 comments
Closed

Suggest to add a phase completed for podgroup #2056

Thor-wl opened this issue Mar 7, 2022 · 8 comments
Assignees
Labels
area/controllers kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@Thor-wl
Copy link
Contributor

Thor-wl commented Mar 7, 2022

No description provided.

@Thor-wl Thor-wl added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 7, 2022
@william-wang
Copy link
Member

It's reasonable and necesary, currenlty we have to use multiple conditional judgments to check whether the podgroup is completed. Please refer to #2038.

@shinytang6
Copy link
Member

Let me take it!
/assign @shinytang6

@Thor-wl Thor-wl added area/controllers and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 14, 2022
@k82cn
Copy link
Member

k82cn commented Mar 26, 2022

Any more backgroup about this issue?

@shinytang6
Copy link
Member

shinytang6 commented Mar 26, 2022

Any more backgroup about this issue?

Give a scene I met:
If the upper job we use is not vcjob, e.g paddlejob, when the paddlejob task is completed (not deleted) and cleanPodPolicy set to OnCompletion, the corresponding podgroup will still exist, it will eventually change to the inqueue state, resulting in unnecessary resource occupation. Therefore, l hope to introduce a completed podgroup state to refer to the already completed job.

This phenomenon is kindy like #1853, but the difference is that the job is not deleted but finished.

@stale
Copy link

stale bot commented Jun 27, 2022

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 27, 2022
@Thor-wl
Copy link
Contributor Author

Thor-wl commented Jul 5, 2022

@shinytang6 Is there any process about the following development such as cm?

@stale stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2022
@stale
Copy link

stale bot commented Oct 12, 2022

Hello 👋 Looks like there was no activity on this issue for last 90 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for 60 days, this issue will be closed (we can always reopen an issue if we need!).

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2022
@stale
Copy link

stale bot commented Dec 31, 2022

Closing for now as there was no activity for last 60 days after marked as stale, let us know if you need this to be reopened! 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controllers kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants