feat(apis): add completed state to podgroup&queue #66
Conversation
shinytang6
force-pushed
the
feat/new-pg-state
branch
2 times, most recently
from
2f2e235 to
c92b255
Compare
|
Pls help take a look :) |
volcano-sh-bot
requested review from
hwdef,
k82cn,
Thor-wl,
william-wang and
Yikun
pkg/apis/scheduling/v1beta1/types.go
Outdated
| @@ -289,6 +292,8 @@ type QueueStatus struct { | |||
| Running int32 `json:"running,omitempty" protobuf:"bytes,4,opt,name=running"` | |||
| // The number of `Inqueue` PodGroup in this queue. | |||
| Inqueue int32 `json:"inqueue,omitempty" protobuf:"bytes,5,opt,name=inqueue"` | |||
| // The number of `Completed` PodGroup in this queue. | |||
| Completed int32 `json:"completed,omitempty" protobuf:"bytes,5,opt,name=completed"` | |||
There was a problem hiding this comment.
changed it to 7 due to 6 already exists
hack/generate-internal-groups.sh
Outdated
| @@ -47,7 +47,7 @@ EXT_APIS_PKG="$4" | |||
| GROUPS_WITH_VERSIONS="$5" | |||
| shift 5 | |||
|
|
|||
| go get k8s.io/code-generator/cmd/{defaulter-gen,conversion-gen,client-gen,lister-gen,informer-gen,deepcopy-gen,openapi-gen}@v0.23.0 | |||
| go install k8s.io/code-generator/cmd/{defaulter-gen,conversion-gen,client-gen,lister-gen,informer-gen,deepcopy-gen,openapi-gen}@v0.23.0 | |||
There was a problem hiding this comment.
It may be better to include the patch updating get to install to a spearated commit.
|
BTW, why add |
Signed-off-by: shinytang6 <1074461480@qq.com>
shinytang6
force-pushed
the
feat/new-pg-state
branch
from
c92b255 to
b2d3cf9
Compare
| @@ -51,6 +51,9 @@ const ( | |||
| // PodGroupInqueue means controllers can start to create pods, | |||
| // is a new state between PodGroupPending and PodGroupRunning | |||
| PodGroupInqueue PodGroupPhase = "Inqueue" | |||
|
|
|||
| // PodGroupCompleted means all the pods of PodGroup are completed | |||
| PodGroupCompleted PodGroupPhase = "Completed" | |||
There was a problem hiding this comment.
How about some Pods are completred but others are failed? Are we going to distinguish succeed & failure?
There was a problem hiding this comment.
My idea is not distinguish succeed & failure pods. In most common scenary, if successful + failed pods == total replicas, we set the PodGroup to Completed.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ref: volcano-sh/volcano#2056