Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we support Job.Spec update #68

Closed
hzxuzhonghu opened this issue Apr 4, 2019 · 2 comments · Fixed by #74
Closed

How do we support Job.Spec update #68

hzxuzhonghu opened this issue Apr 4, 2019 · 2 comments · Fixed by #74

Comments

@hzxuzhonghu
Copy link
Collaborator

I noticed we want to support Job.Spec update in Controller.updateJob

But the generated request is

	req := apis.Request{
		Namespace: newJob.Namespace,
		JobName:   newJob.Name,

		Event: vkbatchv1.OutOfSyncEvent,
	}

But in syncJob
if no pods provided in request, it will create new pods for the Job, and so it will fail, and the following status is unknown.

btw, I am not very familiar with the entire state machine , and maybe i miss something.

@TommyLike
Copy link
Contributor

All the pods are all identified via podName which depends on the jobName&taskName, the syncJob can find out which one to create and which one to delete. It should work but bugs may exist.

@hzxuzhonghu
Copy link
Collaborator Author

What i really mean is we should prevent handling update until we find a way to deal with it.
I am quite sure, the current logic do not support update Job.Spec, if we do, the syncJob will be executed continually again and again.

@k82cn k82cn closed this as completed in #74 Apr 9, 2019
wangyuqing4 pushed a commit to wangyuqing4/volcano-1 that referenced this issue Apr 30, 2019
[Issue volcano-sh#68][BUG2019042800657]add taskTemplate check

before:

task.template din't check full

after:

e.g. if resource limit < request

![image](/uploads/61da812269eb73b009d8a5a0378a420b/image.png)

Issues info:
Issue ID: 68
Title: add check
Issue url: CBU-PaaS/Community/volcano/volcano#68


See merge request CBU-PaaS/Community/volcano/volcano!117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants