Sync unrebased codes #113
Closed
Sync unrebased codes #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Updated Job API.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Add Trivas img.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Added lifecycle policy framework.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Replaced condition by state.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Added Job input/output.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Added Job error handling.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Added Pod events.
Correct typos.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Added suspend/resume.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Job management perf enhancement.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Replaced godep with dep
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Use scheduler name from Job.
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Set default template name.
Updated README.
Add TF example
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Added Queue design doc.
Makefile Cleanup.
Update kube batch source
hzxuzhonghu
reviewed
Apr 29, 2019
pkg/apis/helpers/helpers.go
Outdated
| if _, err := kubeClients.CoreV1().ConfigMaps(job.Namespace).Create(cm); err != nil { | ||
| glog.V(3).Infof("Failed to create ConfigMap for Job <%s/%s>: %v", | ||
| cmOld.Data = data | ||
| if _, err := kubeClients.CoreV1().ConfigMaps(job.Namespace).Update(cmOld); err != nil { |
There was a problem hiding this comment.
Is there a case we need to update configmap?
| @@ -128,24 +140,23 @@ func NewJobController(config *rest.Config) *Controller { | |||
| cc.cmdLister = cc.cmdInformer.Lister() | |||
| cc.cmdSynced = cc.cmdInformer.Informer().HasSynced | |||
|
|
|||
| cc.sharedInformers = informers.NewSharedInformerFactory(cc.kubeClients, 0) | |||
There was a problem hiding this comment.
definitely this code is more clean
| go cc.cmdInformer.Informer().Run(stopCh) | ||
| go cc.sharedInformers.Start(stopCh) | ||
| go cc.pcInformer.Informer().Run(stopCh) |
There was a problem hiding this comment.
The old cc.sharedInformers.Start(stopCh) is same as these lines.
|
let's only do code sync up in this PR; we can open other PRs to address comments. |
…cano into feature/move_codes
|
@k82cn There are some fundamental issues in master branch of CodeClud repo which lead the half failing of our testcases, for example, the pending state does not exist anymore, needs a fix before sync. |
|
let's make sure code sync up firstly. We can fix the issues in different PRs. |
Signed-off-by: Da K. Ma <klaus1982.cn@gmail.com>
Updated kube-batch to vk-kube-batch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are below:
NOTE: It's depends on the feature in kube-batch, should not be merged before that
The synced codes has not been tested, the e2e testcases would fail due to this.
For #112