Combine input & output volumes #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzxuzhonghu
reviewed
May 5, 2019
| @@ -81,8 +78,11 @@ type VolumeSpec struct { | |||
| // not contain ':'. | |||
| MountPath string `json:"mountPath" protobuf:"bytes,1,opt,name=mountPath"` | |||
|
|
|||
| // defined the PVC name | |||
| VolumeClaimName string `json:"volumeClaimName,omitempty" protobuf:"bytes,2,opt,name=volumeClaimName"` | |||
There was a problem hiding this comment.
Why would u add this? Would prefer auto gen it.
There was a problem hiding this comment.
Yeah, there would be a few codes which can be optimized, would like to do it when the initial sync patch get merged.
TommyLike
force-pushed
the
feature/combine_volumes
branch
from
fa9fcc4 to
b7ecae3
Compare
TommyLike
force-pushed
the
feature/combine_volumes
branch
from
b7ecae3 to
71defce
Compare
|
/lgtm |
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Jun 28, 2019
…umes Combine input & output volumes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync feature of combine input & output volumes.
For #122