Fix log tailed issue #132
Merged
Fix log tailed issue #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyLike
force-pushed
the
bug/fix_log_issue
branch
4 times, most recently
from
24f1023 to
666cd51
Compare
|
@k82cn please take a look |
|
any reason not the whole logs? |
TommyLike
force-pushed
the
bug/fix_log_issue
branch
from
666cd51 to
b5e3428
Compare
|
@hzxuzhonghu since it's only used in CI environment, it would be great to limit the whole size if the limit can cover most of the cases. But as you said, it's worth discussing. |
|
It's better if these log files can be downloaded. |
|
@hzxuzhonghu can be uploaded to external storage, for instance S3. |
|
/lgtm |
|
/approve |
volcano-sh-bot
added
the
approved
|
/lgtm |
|
/lgtm |
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Jun 28, 2019
Fix log tailed issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with label filter option,
Kubectl logswould tail logs in 10 lines in default, this patch increases it to 10000