version related changes #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyLike
reviewed
May 8, 2019
pkg/version/version.go
Outdated
| ) | ||
|
|
||
| var ( | ||
| // Version shows the version of kube batch. |
pkg/version/version.go
Outdated
| var ( | ||
| // Version shows the version of kube batch. | ||
| Version = "Not provided." | ||
| // GitSHA shoows the git commit id of kube batch. |
pkg/version/version.go
Outdated
|
|
||
| // PrintVersionAndExit prints versions from the array returned by Info() and exit | ||
| func PrintVersionAndExit() { | ||
| apiVersion := "v1alpha1" |
There was a problem hiding this comment.
Should be moved into a seperated section outside of the function.
do you want me to change the image tag? |
version related flags are not being passed when execute |
|
@TommyLike , seems randomly some e2e test cases are failing. as this PR doesn't have any relation with the tcs but still tcs r failed. can we trigger travis once again. |
|
/lgtm |
|
/lgtm |
volcano-sh-bot
added
the
approved
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Jun 28, 2019
version related changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added version in vkctl, vk-admission & vk-controller
For #77
sample output
root@root1-HP-EliteBook-840-G2:/home/root1/SriniCH/workspace/src/volcano.sh/volcano# ./_output/bin/vk-admission --version
API Version: v1alpha1
Version: v0.1
Git SHA: e08f588
Built At: 2019-05-08 13:57:25
Go Version: go1.11.5
Go OS/Arch: linux/amd64
root@root1-HP-EliteBook-840-G2:/home/root1/SriniCH/workspace/src/volcano.sh/volcano# ./_output/bin/vk-controllers --version
API Version: v1alpha1
Version: v0.1
Git SHA: e08f588
Built At: 2019-05-08 13:57:22
Go Version: go1.11.5
Go OS/Arch: linux/amd64
root@root1-HP-EliteBook-840-G2:/home/root1/SriniCH/workspace/src/volcano.sh/volcano# ./_output/bin/vkctl version
API Version: v1alpha1
Version: v0.1
Git SHA: e08f588
Built At: 2019-05-08 13:57:28
Go Version: go1.11.5
Go OS/Arch: linux/amd64