Leaves kill job to GC #156
Conversation
| @@ -26,6 +26,7 @@ type finishedState struct { | |||
| } | |||
|
|
|||
| func (ps *finishedState) Execute(action vkv1.Action) error { | |||
| // In finished state, e.g. Completed, always kill the whole job. | |||
| return KillJob(ps.job, nil) | |||
| // In finished state, e.g. Completed,Terminated, Failed | |||
There was a problem hiding this comment.
does it mean we will be updating the admission webhook as per ttl controller. otherwise GC will not comeinto picture naaa?? am i missing something else?
or we are just leaving it to run so that user can delete after analysing/seeing his app logs etc
Use a mutating admission webhook to set this field dynamically at resource creation time. Cluster administrators can use this to enforce a TTL policy for finished resources.
Use a mutating admission webhook to set this field dynamically after the resource has finished, and choose different TTL values based on resource status, labels, etc.
|
ping @k82cn |
volcano-sh-bot
added
the
needs-rebase
|
@hzxuzhonghu: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This allows users to investigate the task result.