Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Changelog for v0.1 Release #157

Merged
merged 3 commits into from
May 14, 2019

Conversation

asifdxtreme
Copy link
Contributor

#67

@asifdxtreme asifdxtreme requested a review from k82cn May 13, 2019 08:59
@asifdxtreme
Copy link
Contributor Author

/retest

CHANGELOG.md Outdated
## [v0.1](https://github.com/volcano-sh/volcano/tree/v0.1) (2019-05-11)
**Implemented enhancements:**

- Enable robot for Volcano [\#15](https://github.com/volcano-sh/volcano/issues/15)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also highlight other important features.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this release notes is auto-generated, it picks up enhancement based on the issue type we create in github issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're using kind/feature for that, right?

xref #15 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k82cn yes it seems like it picks from that, but looks like kind/feature is not supported by https://github.com/github-changelog-generator/github-changelog-generator

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so what's our next step?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this section, this sections looks like a contradictory one

@k82cn
Copy link
Member

k82cn commented May 14, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels May 14, 2019
@volcano-sh-bot volcano-sh-bot merged commit 027b62d into volcano-sh:master May 14, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants