Add JobType in CLI #158
Merged
Add JobType in CLI #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k82cn
reviewed
May 14, 2019
pkg/cli/job/list.go
Outdated
| @@ -45,6 +45,8 @@ const ( | |||
| Succeeded string = "Succeeded" | |||
| Failed string = "Failed" | |||
| RetryCount string = "RetryCount" | |||
| JobType string = "JobType" | |||
| JobTypeKey string = "volcano.sh/job-type" | |||
k82cn
reviewed
May 14, 2019
pkg/cli/job/list.go
Outdated
| _, err = fmt.Fprintf(writer, fmt.Sprintf("%%-%ds%%-25s%%-12s%%-12d%%-6d%%-10d%%-10d%%-12d%%-10d%%-12d\n", maxNameLen), | ||
| job.Name, job.CreationTimestamp.Format("2006-01-02 15:04:05"), job.Status.State.Phase, replicas, | ||
| _, err = fmt.Fprintf(writer, fmt.Sprintf("%%-%ds%%-25s%%-12s%%-12s%%-12d%%-6d%%-10d%%-10d%%-12d%%-10d%%-12d\n", maxNameLen), | ||
| job.Name, job.CreationTimestamp.Format("2006-01-02 15:04:05"), job.Status.State.Phase, job.ObjectMeta.Labels[JobTypeKey], replicas, |
There was a problem hiding this comment.
if no such label, use Batch or -
There was a problem hiding this comment.
Changed to Batch
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Jun 28, 2019
Add JobType in CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display Job Type in job list in CLI command. Label to be added in JobSpec should be of Format
And CLI command output is
Fixes #142