Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support vkctl job run --limits #181

Merged
merged 3 commits into from
May 18, 2019
Merged

support vkctl job run --limits #181

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4886dc
support vkctl job run --limits
lminzhw May 17, 2019
b3b9fc6
Merge branch 'master' into vkctl_job_run_limits
k82cn May 17, 2019
72d86d6
Merge branch 'master' into vkctl_job_run_limits
k82cn May 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions pkg/cli/job/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ type runFlags struct {
MinAvailable int
Replicas int
Requests string
Limits string
}

var launchJobFlags = &runFlags{}
Expand All @@ -48,6 +49,7 @@ func InitRunFlags(cmd *cobra.Command) {
cmd.Flags().IntVarP(&launchJobFlags.MinAvailable, "min", "m", 1, "the minimal available tasks of job")
cmd.Flags().IntVarP(&launchJobFlags.Replicas, "replicas", "r", 1, "the total tasks of job")
cmd.Flags().StringVarP(&launchJobFlags.Requests, "requests", "R", "cpu=1000m,memory=100Mi", "the resource request of the task")
cmd.Flags().StringVarP(&launchJobFlags.Limits, "limits", "L", "cpu=1000m,memory=100Mi", "the resource limit of the task")
}

var jobName = "job.volcano.sh"
Expand All @@ -63,6 +65,11 @@ func RunJob() error {
return err
}

limit, err := populateResourceListV1(launchJobFlags.Limits)
if err != nil {
return err
}

job := &vkapi.Job{
ObjectMeta: metav1.ObjectMeta{
Name: launchJobFlags.Name,
Expand All @@ -88,6 +95,7 @@ func RunJob() error {
Name: launchJobFlags.Name,
ImagePullPolicy: v1.PullIfNotPresent,
Resources: v1.ResourceRequirements{
Limits: limit,
Requests: req,
},
},
Expand Down