Update README #236
Merged
Update README #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TommyLike
reviewed
Jun 18, 2019
README.md
Outdated
| Install Volcano using following command, | ||
|
|
||
| ``` | ||
| helm install volcano/volcano -namespace <namespace> --name <specified-name> |
There was a problem hiding this comment.
changed to --namespace
TommyLike
reviewed
Jun 18, 2019
README.md
Outdated
|
|
||
| ## Using Volcano Helm Repo | ||
| ## Helm Charts |
There was a problem hiding this comment.
looks like an incorrect level or redundant header
## Helm Charts
There was a problem hiding this comment.
Have removed that header
|
Now we have two different repos which both keep the volcano charts codes? |
Currently we have it in volcano-sh/volcano repo too, once decision on whether to remove or keep it is made, we can update README accordingly. |
|
/lgtm |
|
/lgtm |
|
/approve |
volcano-sh-bot
added
the
approved
|
/lgtm |
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Jun 28, 2019
Update README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm can be installed without cloning code too,
Have added steps in README to install volcano using helm without cloning code.