Adding Events for Action #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
k82cn
reviewed
Jun 20, 2019
| @@ -239,6 +242,11 @@ func (cc *Controller) processNextReq() bool { | |||
| glog.V(3).Infof("Execute <%v> on Job <%s/%s> in <%s> by <%T>.", | |||
| action, req.Namespace, req.JobName, jobInfo.Job.Status.State.Phase, st) | |||
|
|
|||
| if action != vkbatchv1.SyncJobAction { | |||
| cc.recordJobEvent(jobInfo.Job.Namespace, jobInfo.Job.Name, vkbatchv1.ExecuteAction, fmt.Sprintf( | |||
There was a problem hiding this comment.
That's ok to record event for SyncJobAction.
There was a problem hiding this comment.
If the syncAction event is included it generates a lot of events. If included it is observed that the spamfilter of EventBroadcaster then blocks the similar events on that job object. Because of which new events like restartjob/completejob events were not getting send to the api server.
|
/lgtm |
volcano-sh-bot
added
approved
kevin-wangzefeng
pushed a commit
to kevin-wangzefeng/volcano
that referenced
this pull request
Jun 28, 2019
Adding Events for Action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding events for all the actions on the job except the syncjob
#56