Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log issue when failed to update job #277

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Fix log issue when failed to update job #277

merged 1 commit into from
Jul 3, 2019

Conversation

TommyLike
Copy link
Contributor

When controller failed to update job status, the job object would be empty. And that would leads to the incorrect output of log, see below:

Failed to update status of Job /: Operation cannot be fulfilled on jobs.batch.volcano.sh "mpi": the object has been modified; please apply your changes to the latest version and try again

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 2, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: fb85c330-9cb2-11e9-a963-e5c88ee4513c

@TommyLike TommyLike force-pushed the bug/fix_log_issue2 branch from f08faa6 to 2995384 Compare July 2, 2019 11:42
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 2, 2019
@TommyLike TommyLike force-pushed the bug/fix_log_issue2 branch from 2995384 to e276424 Compare July 2, 2019 11:59
@TravisBuddy
Copy link

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 680cf200-9cc5-11e9-a963-e5c88ee4513c

@TommyLike TommyLike force-pushed the bug/fix_log_issue2 branch from e276424 to 1ba9ab7 Compare July 3, 2019 01:30
@TravisBuddy
Copy link

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 7f013090-9d36-11e9-9589-8781193ec3af

@TommyLike TommyLike force-pushed the bug/fix_log_issue2 branch from 1ba9ab7 to 737458e Compare July 3, 2019 03:08
@k82cn
Copy link
Member

k82cn commented Jul 3, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 3, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2019
@volcano-sh-bot volcano-sh-bot merged commit cebe8bb into volcano-sh:master Jul 3, 2019
This was referenced Jul 3, 2019
Merged
Closed
kevin-wangzefeng pushed a commit that referenced this pull request Jul 4, 2019
@k82cn
Merge pull request #277 from k82cn/ka_273_2
e7de4ea 
Removed duplicated PDB informer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TommyLike @TravisBuddy @k82cn @volcano-sh-bot