Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating submodule before testing #295

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Updating submodule before testing #295

merged 1 commit into from
Jul 9, 2019

Conversation

TommyLike
Copy link
Contributor

see above

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2019
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 5, 2019
@TommyLike
Copy link
Contributor Author

This change is debatable and needs waiting the merge of chart change

@TommyLike TommyLike changed the title [WIP]Updating submodule before testing Updating submodule before testing Jul 5, 2019
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: e6426420-9f0e-11e9-9e24-3df77584075c

k82cn added a commit that referenced this pull request Jul 6, 2019
@k82cn
Merge pull request #295 from k82cn/ffdl_contrib
10bca19 
Added FfDL directory for contribute.
@k82cn
Copy link
Member

k82cn commented Jul 7, 2019

/retest

@TommyLike
Copy link
Contributor Author

@k82cn test would fail until the merge of chart change: volcano-retired/charts#7

@TommyLike
Copy link
Contributor Author

@k82cn it's working now.

@k82cn
Copy link
Member

k82cn commented Jul 9, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@volcano-sh-bot volcano-sh-bot merged commit b3112a7 into volcano-sh:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TommyLike @TravisBuddy @k82cn @volcano-sh-bot