Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep ensure #303

Merged
merged 1 commit into from
Jul 8, 2019
Merged

dep ensure #303

merged 1 commit into from
Jul 8, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu commented Jul 8, 2019

go mod is officially supported dependency pkg management tool, maybe will be enabled by default in go 1.13.

EDIT: Can not use go mod now, as go mod can not vendor k8s.io/code-generator@kubernetes-1.13.2

@volcano-sh-bot volcano-sh-bot added sig/api-machinery approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 8, 2019
@hzxuzhonghu hzxuzhonghu mentioned this pull request Jul 8, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 3c9ddae0-a129-11e9-b4a0-0f4450928f2b

@volcano-sh-bot volcano-sh-bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: dbb2be10-a12f-11e9-b4a0-0f4450928f2b

@k82cn
Copy link
Member

k82cn commented Jul 8, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 510bcf70-a168-11e9-b4a0-0f4450928f2b

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f5189350-a168-11e9-b4a0-0f4450928f2b

@hzxuzhonghu hzxuzhonghu changed the title migrate from dep to go mod dep ensure Jul 8, 2019
@k82cn
Copy link
Member

k82cn commented Jul 8, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2019
@volcano-sh-bot volcano-sh-bot merged commit 5b98aff into volcano-sh:master Jul 8, 2019
@hzxuzhonghu hzxuzhonghu deleted the mod branch July 9, 2019 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants