Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update kube-batch to scheduler #313

Merged
merged 4 commits into from
Jul 11, 2019
Merged

Update kube-batch to scheduler #313

merged 4 commits into from
Jul 11, 2019

Conversation

asifdxtreme
Copy link
Contributor

No description provided.

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2019
@volcano-sh-bot volcano-sh-bot requested review from hex108 and k82cn July 9, 2019 11:38
@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2019
@asifdxtreme asifdxtreme changed the title WIP: Update kube-batch to scheduler Update kube-batch to scheduler Jul 9, 2019
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 9, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @asifdxtreme,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: a654a590-a241-11e9-bee2-e9a995d9559a

thandayuthapani pushed a commit to thandayuthapani/volcano that referenced this pull request Jul 9, 2019
@k82cn
Merge pull request volcano-sh#313 from k82cn/mul_e2e
2e82aa9 
Added e2e for multiple jobs.
k82cn
k82cn reviewed Jul 9, 2019
View reviewed changes
Makefile Outdated
@@ -13,13 +13,13 @@ LD_FLAGS=" \

.EXPORT_ALL_VARIABLES:

all: kube-batch vc-controllers vc-admission vkctl
all: scheduler vc-controllers vc-admission vkctl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vc-scheduler

@k82cn
Copy link
Member

k82cn commented Jul 9, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asifdxtreme, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@TommyLike
Copy link
Contributor

/lgtm

@hex108
Copy link
Contributor

hex108 commented Jul 10, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 11, 2019
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 11, 2019
@hex108
Copy link
Contributor

hex108 commented Jul 11, 2019

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@volcano-sh-bot volcano-sh-bot merged commit c1cbbc1 into volcano-sh:master Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@hex108 hex108 Awaiting requested review from hex108

Assignees

@hex108 hex108

@TommyLike TommyLike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@asifdxtreme @TravisBuddy @k82cn @volcano-sh-bot @TommyLike @hex108