-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set drf dominant resource name #320
Conversation
/lgtm |
Using annotation for PodGroup.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -155,23 +158,25 @@ func (drf *drfPlugin) OnSessionOpen(ssn *framework.Session) { | |||
} | |||
|
|||
func (drf *drfPlugin) updateShare(attr *drfAttr) { | |||
attr.share = drf.calculateShare(attr.allocated, drf.totalResource) | |||
attr.dominantResource, attr.share = drf.calculateShare(attr.allocated, drf.totalResource) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where will dominantResource
be used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be logged
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hex108, hzxuzhonghu, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.