Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue in makefile #326

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Conversation

SrinivasChilveri
Copy link
Contributor

root@root1-HP-EliteBook-840-G2:/home/root1/SriniCH/workspace/src/volcano.sh/volcano# make
make: *** No rule to make target 'vc-scheduler', needed by 'all'. Stop.

this issue is there on latest code with commit

commit c1cbbc1

make should build the binaries properly, but its failing because of recent changes.

@volcano-sh-bot volcano-sh-bot requested review from hex108 and k82cn July 11, 2019 07:03
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 11, 2019
@hex108
Copy link
Contributor

hex108 commented Jul 11, 2019

@asifdxtreme The CI could not find this kind of issue?

@hex108
Copy link
Contributor

hex108 commented Jul 11, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hex108, SrinivasChilveri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2019
@volcano-sh-bot volcano-sh-bot merged commit 6e08482 into volcano-sh:master Jul 11, 2019
thandayuthapani pushed a commit to thandayuthapani/volcano that referenced this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants