-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README #327
Update README #327
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -63,7 +63,33 @@ You can watch industry experts talking about Volcano in different International | |
|
||
The easiest way to deploy Volcano is to use the Helm chart. Volcano can be deployed by cloning code and also by adding helm repo. | ||
|
||
## Using Volcano Helm Repo | ||
## Install Helm | ||
|
||
### Download Helm | ||
|
||
Install helm by following official guide - https://github.com/helm/helm/blob/master/docs/install.md | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it is too complicated, as a newer, he would not want to install No one like complicated thing. If possible, can we remove dependency on helm totally? @k82cn @TommyLike There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @hzxuzhonghu maybe you can bring the practice from istio? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm ok with that. IMO, it's complex because of security, e.g. RBAC; maybe we can provide a quick guidance which ignore security to make it simpler. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FYI: And when it comes to kubernetes, we can run ./hack/local-ip-cluster.sh to start a cluster for developing and testing. |
||
|
||
### Setup Helm | ||
|
||
Since Tiller needs cluster-admin RBAC access, create `ServiceAccount` and `ClusterRoleBinding` by following the offical guide - https://github.com/helm/helm/blob/master/docs/rbac.md | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's give an example here; I don-t think a new user will go through the whole doc of rbac for volcano installation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure! Will add step to add serviceaccount creation and such There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @k82cn Have added steps to create serviceaccount and clusterrolebinding for tiller in README There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. hm... if the following steps about serviceaccount is the |
||
|
||
Create `ServiceAccount` and `ClusterRoleBinding` for tiller | ||
```bash | ||
kubectl create serviceaccount --namespace kube-system tiller | ||
kubectl create clusterrolebinding tiller-cluster-rule --clusterrole=cluster-admin --serviceaccount=kube-system:tiller | ||
``` | ||
|
||
Then `helm init` using created `ServiceAccount` | ||
|
||
```bash | ||
helm init --service-account <ServiceAccountName> --kubeconfig ${KUBECONFIG} --wait | ||
|
||
e.g : | ||
helm init --service-account tiller --kubeconfig ${KUBECONFIG} --wait | ||
``` | ||
|
||
## 1. Using Volcano Helm Repo | ||
|
||
Add helm repo using following command, | ||
|
||
|
@@ -80,15 +106,15 @@ e.g : | |
helm install volcano/volcano --namespace volcano-trial --name volcano-trial | ||
``` | ||
|
||
## Cloning Code | ||
## 2. Cloning Code | ||
### Pre-requisites | ||
|
||
First of all, clone the repo to your local path: | ||
|
||
``` | ||
# mkdir -p $GOPATH/src/volcano.sh/ | ||
# cd $GOPATH/src/volcano.sh/ | ||
# git clone --recursive https://github.com/volcano-sh/volcano.git | ||
# git clone https://github.com/volcano-sh/volcano.git | ||
``` | ||
|
||
### 1. Volcano Image | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about make this under quick start guide and change it to Install Volcano?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not we provide the helm document link here and note about the RBAC issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TommyLike Sure, will change that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TommyLike Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's better to highlight chart version/branch if using volcano/chart. We're going to update master when releasing.