Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omit pods not controlled by volcano #330

Merged
merged 2 commits into from
Jul 15, 2019
Merged

omit pods not controlled by volcano #330

merged 2 commits into from
Jul 15, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

This is to fix #311

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 11, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: bbb6b110-a3d3-11e9-8928-81693ac37660

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 93e56770-a3d4-11e9-8928-81693ac37660

@k82cn
Copy link
Member

k82cn commented Jul 11, 2019

/approve

This one is better :)

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2019
TommyLike
TommyLike reviewed Jul 11, 2019
View reviewed changes
pkg/controllers/job/job_controller_handler.go
return
}

if newPod.ResourceVersion == oldPod.ResourceVersion {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, in which case we will have the same resource version for old and new object?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resync

@TommyLike
Copy link
Contributor

UT is failing

coverage: 33.7% of statements
ok  	volcano.sh/volcano/pkg/controllers/garbagecollector	0.029s	coverage: 33.7% of statements
# volcano.sh/volcano/pkg/controllers/job [volcano.sh/volcano/pkg/controllers/job.test]
pkg/controllers/job/job_controller_handler.go:136: undefined: IsControlledBy
pkg/controllers/job/job_controller_handler.go:195: undefined: IsControlledBy
pkg/controllers/job/job_controller_handler.go:288: undefined: IsControlledBy

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4826ac60-a6bb-11e9-a3be-7d74802580dc

thandayuthapani pushed a commit to thandayuthapani/volcano that referenced this pull request Jul 15, 2019
@k82cn
Merge pull request volcano-sh#330 from k82cn/ka_328_2
ccee1d5 
Fixed potential division by zero.
@k82cn
Copy link
Member

k82cn commented Jul 15, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit a0a4246 into master Jul 15, 2019
@hzxuzhonghu hzxuzhonghu deleted the job-log branch July 15, 2019 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyLike TommyLike TommyLike left review comments

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Volcano controller logs is too noisy
5 participants
@hzxuzhonghu @TravisBuddy @k82cn @TommyLike @volcano-sh-bot