Register webhook in codes

[TommyLike]

For Issue #329, Within this change, admission webhook configs as below are registered in admission codes automatically. Therefore this yaml can be removed.

apiVersion: admissionregistration.k8s.io/v1beta1
kind: ValidatingWebhookConfiguration
metadata:
  name: {{ .Release.Name }}-validate-job
  annotations:
    "helm.sh/hook": pre-install
    "helm.sh/hook-delete-policy": before-hook-creation
webhooks:
  - clientConfig:
      service:
        name: {{ .Release.Name }}-admission-service
        namespace: {{ .Release.Namespace }}
        path: /jobs
    failurePolicy: Ignore
    name: validatejob.volcano.sh
    namespaceSelector: {}
    rules:
      - apiGroups:
          - "batch.volcano.sh"
        apiVersions:
          - "v1alpha1"
        operations:
          - CREATE
          - UPDATE
        resources:
          - jobs
---
apiVersion: admissionregistration.k8s.io/v1beta1
kind: MutatingWebhookConfiguration
metadata:
  name: {{ .Release.Name }}-mutate-job
  annotations:
    "helm.sh/hook": pre-install
    "helm.sh/hook-delete-policy": before-hook-creation
webhooks:
  - clientConfig:
      service:
        name: {{ .Release.Name }}-admission-service
        namespace: {{ .Release.Namespace }}
        path: /mutating-jobs
    failurePolicy: Ignore
    name: mutatejob.volcano.sh
    namespaceSelector: {}
    rules:
      - apiGroups:
          - "batch.volcano.sh"
        apiVersions:
          - "v1alpha1"
        operations:
          - CREATE
        resources:
          - jobs

Also, this two configurations have been added the owner reference of admission service, which makes them deleted automatically when purge helm chart.

[TommyLike]

This CI would fail due to the unchange of helm chart.

[TravisBuddy]

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 333d5f20-a480-11e9-bd96-c5bef65e495d

[k82cn]

@TommyLike @hzxuzhonghu @asifdxtreme , can you help to list the items we need to do to improve contributor experience for this? That's really hard to get the progress of that if we open PR one by one :(

[TravisBuddy]

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f240e000-a48e-11e9-bd96-c5bef65e495d

[TommyLike]

@TommyLike @hzxuzhonghu @asifdxtreme , can you help to list the items we need to do to improve contributor experience for this? That's really hard to get the progress of that if we open PR one by one :(

hmm, @k82cn this patch is not related to contributor experience improvement. @hzxuzhonghu has opened an issue which lists most of the things we need to do to improve it. We can discuss and talk on that one。#325

[k82cn]

this patch is not related to contributor experience improvement.

If contributor can not install Volcano, how to contribute?

[TommyLike]

this patch is not related to contributor experience improvement.

If contributor can not install Volcano, how to contribute?

There would be several reasons that leads to failing installing volcano.

1. kubernetes cluster version requirement.
2. misconfiguration of the kubernetes cluster
3. helm binary version requirement.
4. inconsistency between our charts templates and controller images.
5. .....

This patch intends to reduce the yaml amount and does not belong to any of these above.

[TommyLike]

/assign @hzxuzhonghu

[TravisBuddy]

Travis tests have failed

Hey @TommyLike,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d4c4c390-a6e4-11e9-a3be-7d74802580dc

[k82cn]

/lgtm
/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [k82cn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment