Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support release volcano in Travis #344

Merged
merged 5 commits into from
Jul 17, 2019
Merged

Support release volcano in Travis #344

merged 5 commits into from
Jul 17, 2019

Conversation

TommyLike
Copy link
Contributor

This patch enables release volcano when adding new tags. Things included.

  1. Generate single yaml file which can be easily deployed within one command, see helm template.
  2. Upload the docker images tagged with github tag.
  3. Upload github release zip file.

Command for trigger a release would be something like:

git tag v0.0.2 -m/-f
git push origin v0.0.2

Tested on local repo:
image

And the structure of release file would be:

├── bin
│   └── amd64
│       ├── vc-admission
│       ├── vc-controllers
│       ├── vcctl
│       └── vc-scheduler
├── default-queue.yaml
├── helm
│   └── chart
│       └── volcano
│           ├── Chart.yaml
│           ├── config
│           │   ├── kube-batch-ci.conf
│           │   └── kube-batch.conf
│           ├── templates
│           │   ├── admission.yaml
│           │   ├── batch_v1alpha1_job.yaml
│           │   ├── bus_v1alpha1_command.yaml
│           │   ├── controllers.yaml
│           │   ├── default-queue.yaml
│           │   ├── NOTES.txt
│           │   ├── scheduler.yaml
│           │   ├── scheduling_v1alpha1_podgroup.yaml
│           │   ├── scheduling_v1alpha1_queue.yaml
│           │   ├── scheduling_v1alpha2_podgroup.yaml
│           │   └── scheduling_v1alpha2_queue.yaml
│           └── values.yaml
├── README.md
└── volcano-v0.0.6.yaml

Environment variables required in Travis:

  1. DOCKER_PASSWORD
  2. DOCKER_USERNAME
  3. GITHUB_TOKEN

@volcano-sh-bot volcano-sh-bot requested review from hex108 and k82cn July 16, 2019 08:53
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 16, 2019
@TommyLike
Copy link
Contributor Author

@k82cn @hzxuzhonghu

@hzxuzhonghu
Copy link
Collaborator

good

@TommyLike
Copy link
Contributor Author

@asifdxtreme would you mind review and have a try on this patch? I see you published the first release.

@asifdxtreme
Copy link
Contributor

@asifdxtreme would you mind review and have a try on this patch? I see you published the first release.

okay I will have a check at that and updated it in sometime

asifdxtreme
asifdxtreme reviewed Jul 16, 2019
View reviewed changes
hack/publish.sh Outdated Show resolved Hide resolved
@asifdxtreme
Copy link
Contributor

@TommyLike Before actually releasing and uploading the images/release can we just use this release to deploy in kind and run E2E on this?

@k82cn
Copy link
Member

k82cn commented Jul 16, 2019

do we need to have release in every build?

@asifdxtreme
Copy link
Contributor

do we need to have release in every build?

Release will be triggered only if the new tag is pushed in github

@TommyLike
Copy link
Contributor Author

TommyLike commented Jul 16, 2019 •
edited
Loading

@TommyLike Before actually releasing and uploading the images/release can we just use this release to deploy in kind and run E2E on this?

It's been verified before this step. But only for helm chart, not the yaml way.

@asifdxtreme
Copy link
Contributor

  1. We need to skip the other stages which is not relevant for release in tagged commits
  2. I tried this patch with my own fork, https://travis-ci.org/asifdxtreme/volcano/builds/559375980 , the docker images were pushed successfully, however the push binary to release failed.

@TommyLike
Copy link
Contributor Author

TommyLike commented Jul 16, 2019 •
edited
Loading

  1. We need to skip the other stages which is not relevant for release in tagged commits
  2. I tried this patch with my own fork, https://travis-ci.org/asifdxtreme/volcano/builds/559375980 , the docker images were pushed successfully, however the push binary to release failed.

You need github token: GITHUB_TOKEN @asifdxtreme

@asifdxtreme
Copy link
Contributor

  1. We need to skip the other stages which is not relevant for release in tagged commits
  2. I tried this patch with my own fork, https://travis-ci.org/asifdxtreme/volcano/builds/559375980 , the docker images were pushed successfully, however the push binary to release failed.

You need github token: GITHUB_TOKEN

my bad, ran it again after adding GITHUB_TOKEN and it works well https://travis-ci.org/asifdxtreme/volcano/builds/559381486
lgtm overall

@TommyLike TommyLike force-pushed the feature/release_ci branch from d341f13 to aa792fc Compare July 16, 2019 10:50
@k82cn
Copy link
Member

k82cn commented Jul 16, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, TommyLike

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@hzxuzhonghu hzxuzhonghu mentioned this pull request Jul 16, 2019
Closed
hzxuzhonghu
hzxuzhonghu reviewed Jul 17, 2019
View reviewed changes
installer/README.md

All-in-one yaml has been generated for quick deployment. Try command:
```$xslt
kubectl apply -f volcano-v0.0.x.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a guide on how to generate this yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should not be here, since it's only used for the releases and focus on how to use not how to develop.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a step : make xxxx

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the source code is not downloaded in this scenario, it's better to add this steps into developing process.

@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2019
@volcano-sh-bot volcano-sh-bot merged commit bf82213 into volcano-sh:master Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@asifdxtreme asifdxtreme asifdxtreme left review comments

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TommyLike @hzxuzhonghu @asifdxtreme @k82cn @volcano-sh-bot