ignore PredicateFn err info for preempt & reclaim scheduler plugin #3458
Conversation
Signed-off-by: LivingCcj <livingccj@163.com> Signed-off-by: cuichaojie <cuichaojie@bilibili.com>
volcano-sh-bot
added
the
size/S
| @@ -211,10 +211,7 @@ func preempt( | |||
| predicateFn := func(task *api.TaskInfo, node *api.NodeInfo) ([]*api.Status, error) { | |||
| // Allows scheduling to nodes that are in Success or Unschedulable state after filtering by predicate. | |||
| var statusSets util.StatusSets | |||
| statusSets, err := ssn.PredicateFn(task, node) | |||
| if err != nil { | |||
There was a problem hiding this comment.
print the err is better, and we'd better also add some comments to explain why this is removed, like we just concern satus code, which is consistent with kube-scheduler https://github.com/kubernetes/kubernetes/blob/9d87fa215d9e8020abdc17132d1252536cd752d2/pkg/scheduler/framework/preemption/preemption.go#L422
There was a problem hiding this comment.
Yeap, it could place the annotation to mark the reason. however，print err info, there is no much help for next step.
Signed-off-by: LivingCcj <livingccj@163.com> Signed-off-by: cuichaojie <cuichaojie@bilibili.com>
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lowang-bh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
fix issue: #3329