Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add development guide #352

Merged
merged 4 commits into from
Jul 23, 2019
Merged

Add development guide #352

merged 4 commits into from
Jul 23, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu commented Jul 18, 2019 •
edited
Loading

fixes: #325

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2019
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 18, 2019
@hzxuzhonghu
Copy link
Collaborator Author

Need help from @SrinivasChilveri

TommyLike
TommyLike reviewed Jul 18, 2019
View reviewed changes
docs/development/development.md

## Building the code

To build volcano all components for your host architecture, go to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where can I find the output binaries?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

TommyLike
TommyLike reviewed Jul 18, 2019
View reviewed changes
docs/development/development.md
If you want to run e2e test in a existing cluster with volcano deployed, run the following:

```bash
KUBECONFIG=${KUBECONFIG} go test ./test/e2e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need set the VK_BIN environment before running this go test command.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @SrinivasChilveri

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@volcano-sh-bot volcano-sh-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 18, 2019
@SrinivasChilveri
Copy link
Contributor

Need help from @SrinivasChilveri

have added contribution, comminity member ship, trobulble shooting, getting started etc.

@hzxuzhonghu hzxuzhonghu changed the title [WIP] Add development guide Add development guide Jul 19, 2019
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2019
@hzxuzhonghu
Copy link
Collaborator Author

/lgtm

@volcano-sh-bot
Copy link
Contributor

@hzxuzhonghu: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hzxuzhonghu
Copy link
Collaborator Author

@TommyLike any other comments?

@k82cn
Copy link
Member

k82cn commented Jul 23, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2019
@TommyLike
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2019
@volcano-sh-bot volcano-sh-bot merged commit c833efc into volcano-sh:master Jul 23, 2019
@hzxuzhonghu hzxuzhonghu deleted the develop branch July 23, 2019 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SrinivasChilveri SrinivasChilveri SrinivasChilveri left review comments

@TommyLike TommyLike TommyLike left review comments

@hex108 hex108 Awaiting requested review from hex108

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees

@TommyLike TommyLike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributor experience improvement
5 participants
@hzxuzhonghu @SrinivasChilveri @volcano-sh-bot @k82cn @TommyLike