Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read me slack links were not working so changed the same #356

Merged
merged 2 commits into from
Jul 20, 2019
Merged

Read me slack links were not working so changed the same #356

merged 2 commits into from
Jul 20, 2019

Conversation

SrinivasChilveri
Copy link
Contributor

Read me slack links were not working so changed the same

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 18, 2019
k82cn
k82cn reviewed Jul 18, 2019
View reviewed changes
README.md Outdated
Mailing List: https://groups.google.com/forum/#!forum/volcano-sh
[Slack Signup](https://join.slack.com/t/volcano-sh/shared_invite/enQtNTU5NTU3NDU0MTc4LTgzZTQ2MzViNTFmNDg1ZGUyMzcwNjgxZGQ1ZDdhOGE3Mzg1Y2NkZjk1MDJlZTZhZWU5MDg2MWJhMzI3Mjg3ZTk)

[Mailing List](https://groups.google.com/forum/#!forum/volcano-sh)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also show the url in readme.

k82cn
k82cn reviewed Jul 18, 2019
View reviewed changes
README.md Outdated

Mailing List: https://groups.google.com/forum/#!forum/volcano-sh
[Slack Signup](https://join.slack.com/t/volcano-sh/shared_invite/enQtNTU5NTU3NDU0MTc4LTgzZTQ2MzViNTFmNDg1ZGUyMzcwNjgxZGQ1ZDdhOGE3Mzg1Y2NkZjk1MDJlZTZhZWU5MDg2MWJhMzI3Mjg3ZTk)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use short url, e.g. http://t.cn/Efa7LKx

k82cn
k82cn reviewed Jul 18, 2019
View reviewed changes
README.md Outdated
@@ -114,9 +114,9 @@ job.batch/volcano-admission-init 1/1 48s 96s

You can reach the maintainers of this project at:

Slack: [#volcano-sh](volcano-slack). (Signup [here](slack-invitation)).
[Slack Channel](https://volcano-sh.slack.com)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please also show url.

k82cn
k82cn reviewed Jul 19, 2019
View reviewed changes
README.md Outdated
@@ -114,9 +114,9 @@ job.batch/volcano-admission-init 1/1 48s 96s

You can reach the maintainers of this project at:

Slack: [#volcano-sh](volcano-slack). (Signup [here](slack-invitation)).
Slack Channel : https://volcano-sh.slack.com
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like that:

Slack Channel : https://volcano-sh.slack.com , (Signup)

Mailing List: https://groups.google.com/forum/#!forum/volcano-sh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, it seem can not access shorturl.at in china.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so shall i keep as below because short url is not working in china.

Slack Channel : https://volcano-sh.slack.com.[Slack Signup](https://join.slack.com/t/volcano-sh/shared_invite/enQtNTU5NTU3NDU0MTc4LTgzZTQ2MzViNTFmNDg1ZGUyMzcwNjgxZGQ1ZDdhOGE3Mzg1Y2NkZjk1MDJlZTZhZWU5MDg2MWJhMzI3Mjg3ZTk)

Mailing List : https://groups.google.com/forum/#!forum/volcano-sh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@SrinivasChilveri SrinivasChilveri force-pushed the ReadmeLinkIssue branch 3 times, most recently from 822fbba to eaf4ab2 Compare July 19, 2019 06:48
@SrinivasChilveri
Copy link
Contributor Author

@k82cn thanks. changes done.

kevin-wangzefeng
kevin-wangzefeng reviewed Jul 19, 2019
View reviewed changes
README.md
@@ -114,9 +114,9 @@ job.batch/volcano-admission-init 1/1 48s 96s

You can reach the maintainers of this project at:

Slack: [#volcano-sh](volcano-slack). (Signup [here](slack-invitation)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simply remove # before volcano-sh

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And you can use inline link for Signup [here]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevin-wangzefeng ,if we remove # before volcano-sh then also link is not working.
I hope the below one would be fine

Slack: https://volcano-sh.slack.com. (Signup here).

Mailing List: https://groups.google.com/forum/#!forum/volcano-sh

@TravisBuddy
Copy link

Travis tests have failed

Hey @SrinivasChilveri,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: d6a2d220-a9f4-11e9-91b1-f106ceecf692

@k82cn
Copy link
Member

k82cn commented Jul 20, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, SrinivasChilveri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2019
@volcano-sh-bot volcano-sh-bot merged commit ad46a6e into volcano-sh:master Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k82cn k82cn k82cn left review comments

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SrinivasChilveri @TravisBuddy @k82cn @volcano-sh-bot @kevin-wangzefeng