Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate queue/podgroup to v1alpha2 #364

Merged
merged 16 commits into from
Jul 26, 2019
Merged

migrate queue/podgroup to v1alpha2 #364

merged 16 commits into from
Jul 26, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

@hzxuzhonghu hzxuzhonghu commented Jul 19, 2019 •
edited
Loading

fixes: #357

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: f68a0d10-aa0d-11e9-91b1-f106ceecf692

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 677d02d0-aa12-11e9-91b1-f106ceecf692

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2019
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 46562ca0-aaa1-11e9-91b1-f106ceecf692

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 5e345570-aaa3-11e9-91b1-f106ceecf692

@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: bb5aa7a0-aad4-11e9-bd4a-b1db5eb8f7db

@volcano-sh-bot volcano-sh-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 20, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f0522380-aadd-11e9-bd4a-b1db5eb8f7db

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 65d0ff70-aae1-11e9-bd4a-b1db5eb8f7db

@hzxuzhonghu
Copy link
Collaborator Author

/cc @k82cn

@volcano-sh-bot volcano-sh-bot requested a review from k82cn July 22, 2019 11:40
@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2019
@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 23, 2019
@hzxuzhonghu
Copy link
Collaborator Author

/cc @k82cn @TommyLike ptal, and we can do some enhancements following with v1alpha2.

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2019
@hzxuzhonghu
Copy link
Collaborator Author

I will rebase if everything is ok.

TommyLike
TommyLike reviewed Jul 25, 2019
View reviewed changes
pkg/admission/admit_job.go Outdated
@@ -151,8 +151,11 @@ func validateJob(job v1alpha1.Job, reviewResponse *v1beta1.AdmissionResponse) st
}

// Check whether Queue already present or not
// TODO: deprecate v1alpha1
if _, err := KubeBatchClientSet.SchedulingV1alpha1().Queues().Get(job.Spec.Queue, metav1.GetOptions{}); err != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try v2 first.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@TommyLike
Copy link
Contributor

looks good to me, please rebase it.

@volcano-sh-bot volcano-sh-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2019
@TravisBuddy
Copy link

Travis tests have failed

Hey @hzxuzhonghu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 62ecf500-ae94-11e9-bf46-bb10ab8761c4

@k82cn
Copy link
Member

k82cn commented Jul 25, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hzxuzhonghu, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2019
@TommyLike
Copy link
Contributor 

test/e2e/admission.go:100:19: context.vkclient undefined (type *context has no field or method vkclient)
test/e2e/admission.go:150:19: context.vkclient undefined (type *context has no field or method vkclient)

need another fix.

@SrinivasChilveri SrinivasChilveri mentioned this pull request Jul 25, 2019
Closed
@TommyLike
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 26, 2019
@volcano-sh-bot volcano-sh-bot merged commit 71ad4ce into volcano-sh:master Jul 26, 2019
@hzxuzhonghu hzxuzhonghu deleted the v1alpha2 branch July 26, 2019 15:51
@archlitchi archlitchi mentioned this pull request Jun 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyLike TommyLike TommyLike left review comments

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@TommyLike TommyLike

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Added v1alpha2 as default CRD
5 participants
@hzxuzhonghu @TravisBuddy @TommyLike @k82cn @volcano-sh-bot