Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Docker Image in Daily Build #372

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

asifdxtreme
Copy link
Contributor

Partially fixes #347

@volcano-sh-bot volcano-sh-bot requested review from hex108 and k82cn July 22, 2019 05:54
@asifdxtreme asifdxtreme requested review from TommyLike and removed request for hex108 and k82cn July 22, 2019 05:54
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 22, 2019
@asifdxtreme asifdxtreme requested review from k82cn and hex108 July 22, 2019 05:55
.travis.yml Outdated Show resolved Hide resolved
@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 22, 2019
@TommyLike
Copy link
Contributor

thanks @asifdxtreme /lgtm

@@ -58,6 +58,14 @@ jobs:
skip_cleanup: true
on:
tags: true
- stage: Publish latest Docker Image on Daily Build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can ci control it is run once a day?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

condition: $TRAVIS_EVENT_TYPE = cron it is based on this condition
currently cron job is configured to run daily once

@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019
@k82cn
Copy link
Member

k82cn commented Jul 22, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asifdxtreme, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2019
@volcano-sh-bot volcano-sh-bot merged commit 00d9a2a into volcano-sh:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README document update follow ups
5 participants