Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fix a bug when the hostname label of a node does not match the node name, pods bound to a PV with nodeAffinity using the hostname may be scheduled to the wrong node or experience scheduling failures. #3837

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix: Fix a bug when the hostname label of a node does not match the node name, pods bound to a PV with nodeAffinity using the hostname may be scheduled to the wrong node or experience scheduling failures. #3837

merged 1 commit into from
Dec 17, 2024

Conversation

dongjiang1989
Copy link
Contributor

@dongjiang1989 dongjiang1989 commented Nov 25, 2024 •
edited
Loading

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 25, 2024
@dongjiang1989 dongjiang1989 reopened this Nov 25, 2024
@dongjiang1989
Copy link
Contributor Author

/cc @hwdef @Monokaix PTAL

@volcano-sh-bot
Copy link
Contributor

@dongjiang1989: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only volcano-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hwdef @Monokaix PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dongjiang1989 dongjiang1989 mentioned this pull request Dec 4, 2024
Merged
@dongjiang1989 dongjiang1989 force-pushed the update-k8s-1.31.3 branch 2 times, most recently from d5d6e38 to 3d7a006 Compare December 5, 2024 06:45
@dongjiang1989
Copy link
Contributor Author

Thanks @Monokaix
Please re-check it.

@Monokaix
Copy link
Member

This pr volcano-sh/apis#146 has been merged, and please update the go mod: )

@dongjiang1989
Copy link
Contributor Author

dongjiang1989 commented Dec 10, 2024 •
edited
Loading

This pr volcano-sh/apis#146 has been merged, and please update the go mod: )

Maybe use apis new tag? @Monokaix
Just use apis@master done.

Can you add label to merge it, Thanks

@dongjiang1989 dongjiang1989 force-pushed the update-k8s-1.31.3 branch 3 times, most recently from 6f749a9 to e6992e5 Compare December 10, 2024 07:06
@volcano-sh-bot volcano-sh-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 10, 2024
@dongjiang1989
support add volumebinding
e55ce96 
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>

update crds

Signed-off-by: dongjiang <dongjiang1989@126.com>
@dongjiang1989 dongjiang1989 reopened this Dec 10, 2024
@Monokaix
Copy link
Member

I think it's better to split it into two commits, one is for auo gerneate yaml and another one is fix volume binding err: )

@Monokaix
Copy link
Member

/ok-to-test
/approve

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 13, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2024
lowang-bh
lowang-bh reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@lowang-bh lowang-bh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@volcano-sh-bot volcano-sh-bot merged commit 96af1d3 into volcano-sh:master Dec 17, 2024
28 of 29 checks passed
@dongjiang1989 dongjiang1989 deleted the update-k8s-1.31.3 branch December 18, 2024 09:38
@dongjiang1989 dongjiang1989 restored the update-k8s-1.31.3 branch December 25, 2024 01:42
@dongjiang1989 dongjiang1989 deleted the update-k8s-1.31.3 branch December 25, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lowang-bh lowang-bh lowang-bh left review comments

@Monokaix Monokaix Monokaix left review comments

@jiangkaihua jiangkaihua Awaiting requested review from jiangkaihua

@k82cn k82cn Awaiting requested review from k82cn

@hwdef hwdef Awaiting requested review from hwdef

Assignees

@lowang-bh lowang-bh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dongjiang1989 @volcano-sh-bot @Monokaix @lowang-bh