-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add global maxRetry option #3846
base: master
Are you sure you want to change the base?
doc: add global maxRetry option #3846
Conversation
e3e0a56
to
6b387bd
Compare
example/jobflow/JobFlow.yaml
Outdated
flows: | ||
- name: a | ||
patch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the function of patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the maxRetry of task a is different from the global maxRetry setting, the patch method is supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean, I don't know the necessity of this field. It seems to be fine without it. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm... 🤔️ Thanks @hwdef
In my usage scenario, I still need to Patch some information to replace the content of the JobTemplate. Avoid partial differences causing an explosion in the number of JobTemplates.
ref: https://github.com/volcano-sh/volcano/blob/master/docs/design/jobflow/README.md Patch
section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean, I don't know the necessity of this field. It seems to be fine without it. What do you think?
+1, I also think that this field is unnecessary. Or you can reflect the purpose of this field in the design doc (code logic design), which will make it easier for everyone to understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I mean, I don't know the necessity of this field. It seems to be fine without it. What do you think?
+1, I also think that this field is unnecessary. Or you can reflect the purpose of this field in the design doc (code logic design), which will make it easier for everyone to understand.
Thanks @googs1025
One User case:
apiVersion: flow.volcano.sh/v1alpha1
kind: JobTemplate
metadata:
name: a
spec:
tasks:
- spec:
containers:
- image: tf2.16-cuda11-xxx:v1.0.1
command:
- sh
- -c
- ./script.py --dateset a.txt --mode 1
imagePullPolicy: IfNotPresent
name: nginx
resources:
requests:
cpu: "1"
restartPolicy: OnFailure
---
apiVersion: flow.volcano.sh/v1alpha1
kind: JobFlow
metadata:
name: test-flow1
namespace: default
spec:
jobRetainPolicy: delete
flows:
- name: a
---
apiVersion: flow.volcano.sh/v1alpha1
kind: JobFlow
metadata:
name: test-flow2
namespace: default
spec:
jobRetainPolicy: delete
- name: a
patch:
spec:
tasks:
- spec:
containers:
- image: tf2.16-cuda11-xxx:v1.0.2 # just different image
command:
- sh
- -c
- ./script.py --dateset b.txt --mode 2 # just different args
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am more concerned about the role of patch and whether this patch is necessary because it will make cr more complicated. The patch field alone cannot let users know what the role is.
/lgtm |
Hi @hwdef When will volcano/apis be released? Use new apis version to generate new CRD. |
sorry I do not know about this. |
Can you tell me which CRD are you going to use? |
|
/lgtm cancel |
I prefer the following definition type Flow struct {
// +kubebuilder:validation:MinLength=1
// +required
Name string `json:"name"`
// +optional
DependsOn *DependsOn `json:"dependsOn,omitempty"`
// +optional
MaxRetry *MaxRetry `json:"maxRetry,omitempty"`
} |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I agree. Change it to design done. |
@googs1025 |
I'm ok with this. |
I think we should squash commit to one |
cd69649
to
f8bf78d
Compare
Thanks @googs1025 @hwdef |
f8bf78d
to
9cf918d
Compare
@hwdef Please add label to merge it, thanks |
Signed-off-by: dongjiang <dongjiang1989@126.com>
9cf918d
to
fb6f737
Compare
add global jobRetry option
ref: #3838