-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vc-scheduler: simplify code for drf-plugin #3858
Conversation
Welcome @bogo-y! |
a98ef39
to
e45a7b9
Compare
/ok-to-test |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0b81566
to
f327547
Compare
@JesseStutler Cloud you take a look? |
Let me trigger others' CIs to see if they can pass your e2e |
Sorry could you change your commit id and commit again? I saw that other PRs have passed this e2e testing, and I have reviewed the e2e testing, it should not have problems. If it still fails, I will follow up later. Sorry to take your time. Recently I've been a little busy. |
Please keep a clean commit: ) |
Replace the if-else statement with the min func provided by Go. Signed-off-by: bogo_y <mail@bogo.ac.cn>
Now it seems to be ok... |
I hope it will not affect your enthusiasm for contribution. If there are any problems with CI, you can report it in the community and we will follow up when we have time. I hope you will continue to contribute to volcano! |
/lgtm |
Replace the if-else statement with the min func provided by Go.