Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vc-scheduler: simplify code for drf-plugin #3858

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

bogo-y
Copy link
Contributor

@bogo-y bogo-y commented Dec 6, 2024

Replace the if-else statement with the min func provided by Go.

@volcano-sh-bot
Copy link
Contributor

Welcome @bogo-y!

It looks like this is your first PR to volcano-sh/volcano.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 6, 2024
@bogo-y bogo-y force-pushed the usemin branch 2 times, most recently from a98ef39 to e45a7b9 Compare December 6, 2024 04:03
@Monokaix
Copy link
Member

Monokaix commented Dec 6, 2024

/ok-to-test
/approve

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 6, 2024
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@bogo-y bogo-y force-pushed the usemin branch 2 times, most recently from 0b81566 to f327547 Compare December 9, 2024 11:22
@bogo-y
Copy link
Contributor Author

bogo-y commented Dec 9, 2024

@JesseStutler Cloud you take a look?

@JesseStutler
Copy link
Member

@JesseStutler Cloud you take a look?

Let me trigger others' CIs to see if they can pass your e2e

@JesseStutler
Copy link
Member

JesseStutler commented Dec 9, 2024

@JesseStutler Cloud you take a look?

Sorry could you change your commit id and commit again? I saw that other PRs have passed this e2e testing, and I have reviewed the e2e testing, it should not have problems. If it still fails, I will follow up later. Sorry to take your time. Recently I've been a little busy.

@Monokaix
Copy link
Member

Please keep a clean commit: )

Replace the if-else statement with the min func provided by Go.

Signed-off-by: bogo_y <mail@bogo.ac.cn>
@bogo-y
Copy link
Contributor Author

bogo-y commented Dec 10, 2024

Please keep a clean commit: )

Now it seems to be ok...
Thanks for your patience and I am glad to do more learning and contribution here.

@JesseStutler
Copy link
Member

Please keep a clean commit: )

Now it seems to be ok... Thanks for your patience and I am glad to do more learning and contribution here.

I hope it will not affect your enthusiasm for contribution. If there are any problems with CI, you can report it in the community and we will follow up when we have time. I hope you will continue to contribute to volcano!

@lowang-bh
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
@volcano-sh-bot volcano-sh-bot merged commit 087d990 into volcano-sh:master Dec 10, 2024
16 checks passed
@bogo-y bogo-y deleted the usemin branch December 10, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants