Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

take gpu-number into consideration #3901

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

take gpu-number into consideration #3901

wants to merge 4 commits into from

Conversation

linuxfhy
Copy link

fix:issue 3824

@linuxfhy
take gpu-number into consideration
08eeb16 
fix:issue 3824

Signed-off-by: linuxfhy <linuxfhy@163.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shinytang6
You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 17, 2024
@archlitchi
Copy link
Contributor

yes, indeed, thanks for fixing that:)
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@archlitchi
Copy link
Contributor

related issue: #3824
documents: https://github.com/user-attachments/files/17811149/GPU.docx

@archlitchi archlitchi removed their assignment Dec 18, 2024
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2024
@linuxfhy linuxfhy marked this pull request as draft December 20, 2024 08:27
@linuxfhy linuxfhy marked this pull request as ready for review December 20, 2024 08:31
@archlitchi
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 23, 2024
@JesseStutler
Copy link
Member

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hudson741 hudson741 Awaiting requested review from hudson741

@lowang-bh lowang-bh Awaiting requested review from lowang-bh

At least 1 approving review is required to merge this pull request.

Assignees

@archlitchi archlitchi

Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@linuxfhy @volcano-sh-bot @archlitchi @JesseStutler @jxs1211