Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hierarchical queue webhook validation use listing podgroups instead #3913

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JesseStutler
Copy link
Member

fix #3911

validation

Steps:

  1. Create a queue parent-queue
  2. Create a running job in parent-queue
  3. Create a queue child-queue as the child of parent-queue
  4. Check whether the create request in step-3 will be rejected by the webhook

The screenshot shows that create a child queue under parent queue which contains podgroups will be rejected:
image

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign monokaix
You can assign the PR to them by writing /assign @monokaix in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2024
Signed-off-by: JesseStutler <chenzicong4@huawei.com>
@JesseStutler
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

queue.status.Running do not increased when create vcjob and pod is running successed.
2 participants