Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chart: add scheduler and controller-manager prometheus scrape annotations #3919

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

7sunarni
Copy link
Contributor

From the values.yaml, the both of controller-manager and scheduler components are enabled metrics by default.
I think we should add some default Prometheus annotations, so the metrics data can be scraped when we install by helm.

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign shinytang6
You can assign the PR to them by writing /assign @shinytang6 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…nnotations

Signed-off-by: 7sunarni <710720732@qq.com>
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 24, 2024
Signed-off-by: 7sunarni <710720732@qq.com>
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 26, 2024
@7sunarni
Copy link
Contributor Author

BTW, I found that the chart forget to clear the admission secret after uninstall it. I add a new commit to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants