Add maxRetry in job controller to prevent endless loop #412
Conversation
volcano-sh-bot
added
the
size/S
| glog.V(2).Infof("Failed to handle Job <%s/%s>: %v", | ||
| jobInfo.Job.Namespace, jobInfo.Job.Name, err) | ||
| // If any error, requeue it. | ||
| queue.AddRateLimited(req) |
There was a problem hiding this comment.
We should update job status and record events accordingly.
There was a problem hiding this comment.
job status and event inside of the Execute function should be enough for this.
There was a problem hiding this comment.
what's kind of event in Execute? How user identify whether it's done?
Travis tests have failedHey @hzxuzhonghu, TravisBuddy Request Identifier: dc61bb10-bd70-11e9-af47-41b3464977ce |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
In case there is invalid job container template(like stated #409 (comment)), that cannot be rejected at volcano admission. The job controller can get into an endless loop error retrying.