Added "enqueue" to the actions in defaultSchedulerConf to fix a bug #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of the new status "enqueue", the scheduler with the default actions "allocate, backfill" will not schedule a job with PodGroupPending status. For example, if a job cannot be scheduled at the submission time due to resource contention, it will never get scheduled even when resources are available later. Simply adding "enqueue" to the action list of defaultSchedulerConf in pkg/scheduler/util.go fixes the problem. actions: "allocate, backfill" ==> actions: "allocate, backfill, enqueue"
|
Welcome @yuanchen8911! |
volcano-sh-bot
added
the
size/XS
k82cn
reviewed
Aug 17, 2019
| @@ -29,7 +29,7 @@ import ( | |||
| ) | |||
|
|
|||
| var defaultSchedulerConf = ` | |||
| actions: "allocate, backfill" | |||
| actions: "allocate, backfill, enqueue" | |||
There was a problem hiding this comment.
that'll be better if put enqueue action before allocate action :)
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k82cn, yuanchen8911 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
|
/lgtm |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of the new status "enqueue", a scheduler with the actions "allocate, backfill" defined in the default configuration will not schedule a job with PodGroupPending status. For example, if a job cannot be scheduled at the submission time due to resource contention, it will never get scheduled even when resources are available later. Simply adding "enqueue" to the action list of defaultSchedulerConf in pkg/scheduler/util.go fixes the problem.
actions: "allocate, backfill" ==> actions: "allocate, backfill, enqueue"